Coding style on bitfields usage and pointers to structures

Alan Modra amodra@gmail.com
Sat Feb 5 06:51:46 GMT 2022


On Tue, Jan 18, 2022 at 08:45:47AM +0300, Dmitry Selyutin wrote:
> Our questions are:
> 1. Does the use of bitfields seems legit here? They simplify the reading,
> but I kinda get an impression that binutils tend to avoid bitfields,
> preferring macros.

Bitfields are fine.  C99 is allowed nowadays.  A lot of bfd and
opcodes is very old code from K&R days.

> 2. Would it be OK if we extend `powerpc_opcode` with a pointer to structure?

Sounds reasonable.

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list