[PATCH 3/7] x86: move / quiesce pre-386 non-16-bit warning

Jan Beulich jbeulich@suse.com
Thu Aug 18 07:21:50 GMT 2022


On 17.08.2022 21:21, H.J. Lu wrote:
> On Tue, Aug 16, 2022 at 12:31 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> Emitting this warning for every insn, including ones having actual
>> errors, is annoying. Introduce a boolean variable to emit the warning
>> just once on the first insn after .arch may have changed the things, and
>> move the warning to output_insn(). (I didn't want to go as far as
>> checking whether the .arch actually turned off the i386 bit, but doing
>> so would be an option.)
>> ---
>> Otoh I wonder whether switching to a pre-386 architecture shouldn't
>> automatically move to CODE_16BIT: Us emitting operand- or address-size
>> prefixes violates the architecture specification. Alternatively we
>> could outright reject such .arch directives when not already in 16-bit
>> mode.

Mind me asking - no opinion here?

> OK.

Thanks.

Jan


More information about the Binutils mailing list