[PATCH] gas: update csect alignment for PPC prefixed instructions on XCOFF

CHIGOT, CLEMENT clement.chigot@atos.net
Wed Jun 23 06:49:04 GMT 2021


>> +++ b/gas/config/tc-ppc.c
>> @@ -4039,6 +4039,10 @@ md_assemble (char *str)
>>         boundaries.  */
>>        frag_align_code (6, 4);
>>        record_alignment (now_seg, 6);
>> +#ifdef OBJ_XCOFF
>> +      /* Update alignment of the containing csect.  */
>> +      symbol_get_tc (ppc_current_csect)->align = 6;
>> +#endif
>
> Is there a possibility that this might decrease alignment?  If so, you
> should write:
> 
>     if (symbol_get_tc (ppc_current_csect)->align < 6)
>        symbol_get_tc (ppc_current_csect)->align = 6;

Any value can be passed for the alignment of csect. Thus, it might be
possible but I doubt it will ever happen. 
Anyway I've updated the patch.

Clément

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gas-update-csect-alignment-for-PPC-prefixed-instruct.patch
Type: application/octet-stream
Size: 1377 bytes
Desc: 0001-gas-update-csect-alignment-for-PPC-prefixed-instruct.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20210623/e8b90990/attachment.obj>


More information about the Binutils mailing list