[PATCH 00/13] CTF dumper improvements, a lookup testsuite, and bugfixes

[H.J. Lu]

On Tue, Jan 5, 2021 at 11:07 AM Nick Alcock <nick.alcock@oracle.com> wrote:
>
> On 5 Jan 2021, H. J. Lu via Binutils uttered the following:
>
> > Can you verify and check in the check_ctf_available change first to
> > unbreak cross binutils?
>
> This is all the same change: check_ctf_available crashes without all the
> other stuff :(
>
> But yes, I'm verifying now. (I presume you see it not only in cross
> builds but in any build with a non-ctf-capable compiler.)

I also got

cc -B/export/build/gnu/tools-build/binutils/build-x86_64-linux/libctf/tmpdir/libctf/
 -O2 -g -Wformat -Werror=format-security   -fcf-protection
-I/export/gnu/import/git/sources/binutils-gdb/libctf/../include
-I/export/gnu/import/git/sources/binutils-gdb/libctf -I. -I./../bfd
-gt -fPIC -shared
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/ambiguous-struct-A.c
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/ambiguous-struct-B.c
-o tmpdir/out.so
Executing on host: sh -c {cc
-B/export/build/gnu/tools-build/binutils/build-x86_64-linux/libctf/tmpdir/libctf/
 -O2 -g -Wformat -Werror=format-security   -fcf-protection
-I/export/gnu/import/git/sources/binutils-gdb/libctf/../include
-I/export/gnu/import/git/sources/binutils-gdb/libctf -I. -I./../bfd
-gt -fPIC -shared
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/ambiguous-struct-A.c
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/ambiguous-struct-B.c
-o tmpdir/out.so 2>&1}  /dev/null libctf.tmp (timeout = 300)
spawn [open ...]^M
cc: error: unrecognized debug output level 't'
cc: error: unrecognized debug output level 't'

and

export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c:
In function 'main':
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c:72:13:
warning: format '%li' expects argument of type 'long int', but
argument 3 has type 'int' [-Wformat=]
   72 |     printf ("member counts differ: %li by direct iteration, "
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   73 |      "%li by ctf_member_count\n", icount, ctf_member_count (fp, type));
      |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           |
      |                                           int
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c:73:9:
note: format string is defined here
   73 |      "%li by ctf_member_count\n", icount, ctf_member_count (fp, type));
      |       ~~^
      |         |
      |         long int
      |       %i
compilation of lookup program
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c
failed with </export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c:
In function 'main':
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c:72:13:
warning: format '%li' expects argument of type 'long int', but
argument 3 has type 'int' [-Wformat=]
   72 |     printf ("member counts differ: %li by direct iteration, "
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   73 |      "%li by ctf_member_count\n", icount, ctf_member_count (fp, type));
      |                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           |
      |                                           int
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c:73:9:
note: format string is defined here
   73 |      "%li by ctf_member_count\n", icount, ctf_member_count (fp, type));
      |       ~~^
      |         |
      |         long int
      |       %i>ERROR: compilation of lookup program
/export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c
failed
UNRESOLVED: /export/gnu/import/git/sources/binutils-gdb/libctf/testsuite/libctf-lookup/struct-iteration.c



-- 
H.J.