asan: heap buffer overflow in _bfd_vms_slurp_egsd

Alan Modra amodra@gmail.com
Tue Jan 5 03:00:11 GMT 2021


	* vms-alpha.c (_bfd_vms_slurp_egsd): Read flags after size check.

diff --git a/bfd/vms-alpha.c b/bfd/vms-alpha.c
index 2c0e8126dc..72d89e518f 100644
--- a/bfd/vms-alpha.c
+++ b/bfd/vms-alpha.c
@@ -1394,14 +1394,13 @@ _bfd_vms_slurp_egsd (bfd *abfd)
 	    flagword old_flags;
 	    unsigned int nameoff = offsetof (struct vms_egst, namlng);
 
-	    old_flags = bfd_getl16 (egst->header.flags);
-
 	    if (nameoff >= gsd_size)
 	      goto too_small;
 	    entry = add_symbol (abfd, &egst->namlng, gsd_size - nameoff);
 	    if (entry == NULL)
 	      return FALSE;
 
+	    old_flags = bfd_getl16 (egst->header.flags);
 	    entry->typ = gsd_type;
 	    entry->data_type = egst->header.datyp;
 	    entry->flags = old_flags;

-- 
Alan Modra
Australia Development Lab, IBM


More information about the Binutils mailing list