[PATCH] ld: Run tmpdir/pr28138 only for native build

H.J. Lu hjl.tools@gmail.com
Wed Aug 11 12:59:17 GMT 2021


On Wed, Aug 11, 2021 at 2:14 AM Nick Clifton <nickc@redhat.com> wrote:
>
> Hi H.J.
>
> >       * PR ld/28138
> >       * testsuite/ld-plugin/lto.exp: Run tmpdir/pr28138 only for
> >       native build.
>
> Approved - please apply - but I do have one small suggestion:
>
> > +     if [string match "PASS" $exec_output] then {
> > +         pass "PR ld/28138"
> > +     } else {
> > +         fail "PR ld/28138"
> > +     }
> > +    } else {
> > +     pass "PR ld/28138"
> > +    }
> > +} else {
> > +    fail "PR ld/28138"
> I think that it would be nice if the pass and fail strings mentioned
> which part of the test passed/failed.  ie:
>
>    pass "PR ld/28138 (build & run)"
>    fail "PR ld/28138 (built ok, run failed)"
>    pass "PR ld/28138 (build only)"
>    fail "PR ld/28138 (did not build)"

Done.  I am checking in this.

Thans.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ld-Update-the-pass-and-fail-strings-of-PR-ld-28138-t.patch
Type: text/x-patch
Size: 1202 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20210811/e2366e09/attachment.bin>


More information about the Binutils mailing list