[PATCH] ld: Run tmpdir/pr28138 only for native build
Nick Clifton
nickc@redhat.com
Wed Aug 11 09:14:39 GMT 2021
Hi H.J.
> * PR ld/28138
> * testsuite/ld-plugin/lto.exp: Run tmpdir/pr28138 only for
> native build.
Approved - please apply - but I do have one small suggestion:
> + if [string match "PASS" $exec_output] then {
> + pass "PR ld/28138"
> + } else {
> + fail "PR ld/28138"
> + }
> + } else {
> + pass "PR ld/28138"
> + }
> +} else {
> + fail "PR ld/28138"
I think that it would be nice if the pass and fail strings mentioned
which part of the test passed/failed. ie:
pass "PR ld/28138 (build & run)"
fail "PR ld/28138 (built ok, run failed)"
pass "PR ld/28138 (build only)"
fail "PR ld/28138 (did not build)"
Cheers
Nick
More information about the Binutils
mailing list