[PATCH 1/2] bfd: remove wrong relocations in .loader section for XCOFF

CHIGOT, CLEMENT clement.chigot@atos.net
Tue Apr 20 06:38:16 GMT 2021


>> The AIX loader doesn't allow R_POS or R_NEG relocations in a read-only
>> csect.
>
> Approved - please apply.

I'm quite new to binutils process. Does this ask me to apply or it's a general 
sentence to say it's ok and who ever can apply can do it ? 
Because AFAIK, I don't have write access on the binutils git. 

> Note: With this patch and the 2/2 patch applied, I encountered a new 
> assembler testsuite failure for a toolchain configured as 
> --target=rs6000-aix4.3.3:
> 
>    FAIL: difference of two undefined symbols
> 
> Upon investigation however it appears that this is actually a deficiency 
> in the gas test itself.  There is code in gas/testsuite/gas/all/gas.exp 
> which decides if the undefined symbols test should be run.  Currently it 
> skips the test for powerpc*-*-aix* targets, but not for rs6000*-*-aix* 
> targets.
> 
> So I will be checking in a patch to fix this shortly.

I have added the skip in the second patch for powerpc*-*-aix*. Because that's what
I'm building. But maybe it should simply be *-*-aix*. 

Clément


More information about the Binutils mailing list