[PATCH] bfd: tweak SET_ARCH_MACH of aout-cris.c

Nick Clifton nickc@redhat.com
Tue May 5 09:30:38 GMT 2020


Hi Gunther,

> I see that the patch was committed as-is. I take it that the cast as used
> in aoutx.h when building r_index are necessary then?

Well not for me at least.  I suppose that using a different compiler might
theoretically cause problems.  But if necessary we can always add the casts
with another patch.

> What about other (mis)uses of bfd_target vectors? Is bypassing them allowed?

It is discouraged.  It can be done of course, and some of the code is so old
that it was never properly reviewed, but for new code I would always recommend
using the vectors.

Cheers
  Nick



More information about the Binutils mailing list