[PATCH] bfd: tweak SET_ARCH_MACH of aout-cris.c

Gunther Nikl gnikl@justmail.de
Mon May 4 18:55:46 GMT 2020


Nick Clifton <nickc@redhat.com> wrote:
> 
> > 2020-04-XX  Gunther Nikl  <gnikl@justmail.de>
> > 
> > 	* aout-cris.c (DEFAULT_ARCH): Delete define.
> > 	(MY_set_arch_mach): Likewise.
> > 	(SET_ARCH_MACH): Use bfd_set_arch_mach with an explicit
> > architecture of bfd_arch_cris.
> > 	(swap_ext_reloc_in): Add casts to r_index extraction. Mask
> > valid bits of r_type before the shift.
>  
> Approved and applied.

Thank you for taking care of the patch!

I see that the patch was committed as-is. I take it that the cast as used
in aoutx.h when building r_index are necessary then? I really don't know
why the casts were added.

What about other (mis)uses of bfd_target vectors? Is bypassing them allowed?
I mean not using a provided BFD_SEND for a vector but calling a function
directly.


Thank you,
Gunther


More information about the Binutils mailing list