[PATCH 4/5] Refine size constraints applied to win32pstatus ELF notes

[Jon Turney]

On 15/07/2020 15:30, Nick Clifton wrote:
> 
>>> Actually it looks to me like almost all of the returns in this function
>>> should be "return FALSE" as there is something wrong with the note...
>>
>> Perhaps the way this is written at the moment is a bit awkward as we don't really distinguish in the return code between (i) the contents of the note are malformed, and (ii) an internal error occurred while processing the note. Do we really want to stop with an error in both cases?
> 
> Hmmm - generate an error/warning message of some kind - definitely.
> Stop on the error - probably not.  After all these are core dumps
> that we are dealing with and the user is going to want to get as
> much information out of them as they can.

So, that seems to be back to 'return TRUE, but with a warning'.

I attempted to address that with the following patch [6/5]