[PATCH 4/5] Refine size constraints applied to win32pstatus ELF notes

Nick Clifton nickc@redhat.com
Wed Jul 15 14:30:46 GMT 2020


Hi Jon,

>> Actually it looks to me like almost all of the returns in this function
>> should be "return FALSE" as there is something wrong with the note...
> 
> Perhaps the way this is written at the moment is a bit awkward as we don't really distinguish in the return code between (i) the contents of the note are malformed, and (ii) an internal error occurred while processing the note. Do we really want to stop with an error in both cases?

Hmmm - generate an error/warning message of some kind - definitely.
Stop on the error - probably not.  After all these are core dumps
that we are dealing with and the user is going to want to get as 
much information out of them as they can.

Cheers
  Nick



More information about the Binutils mailing list