Prefer object over notype symbols when disassembling

[Alan Modra]

On Mon, Jan 06, 2020 at 02:11:23PM +0000, Maciej W. Rozycki wrote:
> On Tue, 17 Dec 2019, Alan Modra wrote:
> 
> > diff --git a/ld/testsuite/ld-mips-elf/eh-frame5.s b/ld/testsuite/ld-mips-elf/eh-frame5.s
> > index 741a021685..cf5a11c37a 100644
> > --- a/ld/testsuite/ld-mips-elf/eh-frame5.s
> > +++ b/ld/testsuite/ld-mips-elf/eh-frame5.s
> > @@ -2,6 +2,7 @@
> >  	.cfi_personality 0x0,local_pers
> >  	.cfi_lsda 0x0,LSDA
> >  	.ent	f1
> > +	.type	f1, @function
> >  f1:
> >  	nop
> >  	.end	f1
> 
>  If this and similar changes throughout are required, then we have a bug 
> somewhere, probably in GAS, because `.ent' is supposed to set STT_FUNCTION 
> for the symbol named, making a `.type' pseudo-op to do the same redundant.  
> Cf. `s_mips_ent' and:
> 
>   symbol_get_bfdsym (symbolP)->flags |= BSF_FUNCTION;
> 
> I'd rather keep the old arrangement in the test suite to provide coverage 
> for this semantics.

I'll admit to going wild and adding .type @function in lots of places
after finding it was needed for some mips tests on mips-sgi-irix.  It
looks like the following files should have my change reverted.  I'll
test and commit.

ld/testsuite/ld-mips-elf/eh-frame5.s
ld/testsuite/ld-mips-elf/ehdr_start-new.s
ld/testsuite/ld-mips-elf/ehdr_start-o32.s
ld/testsuite/ld-mips-elf/mips16-call-global-1.s
ld/testsuite/ld-mips-elf/mips16-intermix-1.s
ld/testsuite/ld-mips-elf/mips16-pic-1b.s
ld/testsuite/ld-mips-elf/mips16-pic-4c.s
ld/testsuite/ld-mips-elf/no-shared-1-n64.s
ld/testsuite/ld-mips-elf/no-shared-1-o32.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-1b-micromips.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-1b.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-2a.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-3b.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-4b.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-5a.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-6-n32c.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-6-n64c.s
ld/testsuite/ld-mips-elf/pic-and-nonpic-6-o32c.s
ld/testsuite/ld-mips-elf/pie.s
ld/testsuite/ld-mips-elf/relax-jalr.s

-- 
Alan Modra
Australia Development Lab, IBM