Prefer object over notype symbols when disassembling

Maciej W. Rozycki macro@linux-mips.org
Mon Jan 6 14:11:00 GMT 2020


On Tue, 17 Dec 2019, Alan Modra wrote:

> diff --git a/ld/testsuite/ld-mips-elf/eh-frame5.s b/ld/testsuite/ld-mips-elf/eh-frame5.s
> index 741a021685..cf5a11c37a 100644
> --- a/ld/testsuite/ld-mips-elf/eh-frame5.s
> +++ b/ld/testsuite/ld-mips-elf/eh-frame5.s
> @@ -2,6 +2,7 @@
>  	.cfi_personality 0x0,local_pers
>  	.cfi_lsda 0x0,LSDA
>  	.ent	f1
> +	.type	f1, @function
>  f1:
>  	nop
>  	.end	f1

 If this and similar changes throughout are required, then we have a bug 
somewhere, probably in GAS, because `.ent' is supposed to set STT_FUNCTION 
for the symbol named, making a `.type' pseudo-op to do the same redundant.  
Cf. `s_mips_ent' and:

  symbol_get_bfdsym (symbolP)->flags |= BSF_FUNCTION;

I'd rather keep the old arrangement in the test suite to provide coverage 
for this semantics.

  Maciej



More information about the Binutils mailing list