[PATCH v4] RISC-V: Gate opcode tables by enum rather than string

Jim Wilson jimw@sifive.com
Wed Sep 4 01:02:00 GMT 2019


On Mon, Sep 2, 2019 at 11:14 PM Kito Cheng <kito.cheng@gmail.com> wrote:
> I've tested that with regression in riscv-gnu-toolchain, LGTM :)

Thanks for testing it.  This looks good to me too.  We lost the
ChangeLog entry, and I noticed two very minor comment typos I missed
on the earlier review, "atleast" should be "at least" and "belongs.
Used" should be "belongs.  Used" as coding conventions call for two
spaces after a period.  I'm happy to fix this stuff myself and commit
the patch.

There is another issue here though which is that the binutils-2.33
branch is scheduled for Sept 7, and this isn't a bug fix, it is
preparation for adding new features.  Do we want to include this now?
Or should we wait until after the branch?

Jim



More information about the Binutils mailing list