Small typo in iconv.m4
Simon Marchi
simon.marchi@polymtl.ca
Wed Nov 7 15:27:00 GMT 2018
On 2018-11-06 11:37, Hafiz Abid Qadeer wrote:
> Hi All,
> I was investigating a character set related problem with windows hosted
> GDB and I tracked it down to a typo in iconv.m4. This typo caused
> libiconv detection to fail and related support was not built into gdb.
>
> The problem is with the following line.
> CPPFLAGS="$LIBS $INCICONV"
> which should have been
> CPPFLAGS="$CPPFLAGS $INCICONV"
>
> OK to commit the attached patch?
>
> 2018-11-06 Hafiz Abid Qadeer <abidh@codesourcery.com>
>
> * config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
> Append $INCICONV to it.
> * gcc/configure: Regenerate.
> * libcpp/configure: Likewise.
> * libstdc++-v3/configure: Likewise.
> * intl/configure: Likewise.
>
> Thanks,
Seems good from my point of view, but I can't approve.
Simon
More information about the Binutils
mailing list