Small typo in iconv.m4

Hafiz Abid Qadeer abid_qadeer@mentor.com
Tue Nov 6 16:37:00 GMT 2018


Hi All,
I was investigating a character set related problem with windows hosted
GDB and I tracked it down to a typo in iconv.m4. This typo caused
libiconv detection to fail and related support was not built into gdb.

The problem is with the following line.
CPPFLAGS="$LIBS $INCICONV"
which should have been
CPPFLAGS="$CPPFLAGS $INCICONV"

OK to commit the attached patch?

2018-11-06  Hafiz Abid Qadeer  <abidh@codesourcery.com>

	* config/iconv.m4 (AM_ICONV_LINK): Don't overwrite CPPFLAGS.
	Append $INCICONV to it.
	* gcc/configure: Regenerate.
	* libcpp/configure: Likewise.
	* libstdc++-v3/configure: Likewise.
	* intl/configure: Likewise.

Thanks,
-- 
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iconv.patch
Type: text/x-patch
Size: 445 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20181106/1c499b90/attachment.bin>


More information about the Binutils mailing list