[PATCH] Cleanup ppc code dealing with opcode dumps

Hans-Peter Nilsson hp@bitrange.com
Sun May 6 12:39:00 GMT 2018


On Sun, 6 May 2018, Alan Modra wrote:
> On Fri, May 04, 2018 at 04:37:34PM -0500, Peter Bergner wrote:
> > gas/
> > 	* config/tc-ppc.c (ppc_setup_opcodes) <powerpc_opcodes>: Rewrite code
> > 	to dump the entire opcode table.
> > 	(ppc_setup_opcodes) <spe2_opcodes>: Likewise.
> > 	(ppc_setup_opcodes) <vle_opcodes>: Likewise.  Fix calculation of
> > 	opcode index.
>
> OK with some ChangeLog fixes.  Normally you'd write the angle brackets
> inside the parentheses, for example:
>
> 	* ppc-dis.c (disassemble_init_powerpc <powerpc_opcd_indices>): Rewrite
> 	initialization loop.

Ackchyually, no, it was correct as written.
<https://www.gnu.org/prep/standards/html_node/Indicating-the-Part-Changed.html>

brgds, H-P



More information about the Binutils mailing list