[PATCH] Cleanup ppc code dealing with opcode dumps

Alan Modra amodra@gmail.com
Sun May 6 06:35:00 GMT 2018


On Fri, May 04, 2018 at 04:37:34PM -0500, Peter Bergner wrote:
> include/
> 	* opcode/ppc.h (powerpc_num_opcodes): Change type to unsigned.
> 	(vle_num_opcodes): Likewise.
> 	(spe2_num_opcodes): Likewise.
> 
> opcodes/
> 	* ppc-opc.c (powerpc_num_opcodes): Likewise.
> 	(vle_num_opcodes): Likewise.
> 	(spe2_num_opcodes): Likewise.
> 	* ppc-dis.c (disassemble_init_powerpc) <powerpc_opcd_indices>: Rewrite
> 	initialization loop.
> 	(disassemble_init_powerpc) <vle_opcd_indices>: Likewise.
> 	(disassemble_init_powerpc) <spe2_opcd_indices>: Likewise.  Initialize
> 	only once.
> 
> gas/
> 	* config/tc-ppc.c (ppc_setup_opcodes) <powerpc_opcodes>: Rewrite code
> 	to dump the entire opcode table.
> 	(ppc_setup_opcodes) <spe2_opcodes>: Likewise.
> 	(ppc_setup_opcodes) <vle_opcodes>: Likewise.  Fix calculation of
> 	opcode index.

OK with some ChangeLog fixes.  Normally you'd write the angle brackets
inside the parentheses, for example:

	* ppc-dis.c (disassemble_init_powerpc <powerpc_opcd_indices>): Rewrite
	initialization loop.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list