[PATCH 3/5] [ARC] Update merging attributes.

[Claudiu Zissulescu]

Hi Nick,

The name can be arbitrary. This attribute is used by various customers to pretty print their specific CPU. What really counts is the CPU_base, and CPU_variation.

When the CPU_name conflicts, then we should choose one of them.

Please let me know if you have extra questions,
Claudiu

> -----Original Message-----
> From: Nick Clifton [mailto:nickc@redhat.com]
> Sent: Tuesday, July 31, 2018 6:05 PM
> To: Claudiu Zissulescu <claziss@gmail.com>; binutils@sourceware.org
> Cc: Francois.Bedard@synopsys.com; Claudiu Zissulescu
> <claziss@synopsys.com>
> Subject: Re: [PATCH 3/5] [ARC] Update merging attributes.
> 
> Hi Claudiu,
> 
> > bfd/
> > 2017-09-19  Claudiu Zissulescu <claziss@synopsys.com>
> >
> > 	* elf32-arc.c (arc_elf_merge_attributes): Fix merge attributes.
> >
> > ld/
> > 2017-09-19  Claudiu Zissulescu <claziss@synopsys.com>
> >
> > 	* testsuite/ld-arc/attr-merge-6.d: New file.
> > 	* testsuite/ld-arc/attr-merge-6a.s: Likewise.
> > 	* testsuite/ld-arc/attr-merge-6b.s: Likewise.
> > 	* testsuite/ld-arc/attr-merge-6bis.d: Likewise.
> 
> 
> >  	case Tag_ARC_CPU_name:
> > +	  if (!out_attr[i].s && in_attr[i].s)
> > +	    out_attr[i].s = _bfd_elf_attr_strdup (obfd, in_attr[i].s);
> >  	  break;
> 
> What should happen if out_attr[i].s and in_attr[i].s are both defined, and
> different ?
> 
> Cheers
>   Nick