[PATCH] ld: amend "ld: Skip unsupported static executable tests"

[H.J. Lu]

On Thu, Aug 2, 2018 at 5:16 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 02.08.18 at 14:08, <hjl.tools@gmail.com> wrote:
>> On Thu, Aug 2, 2018 at 1:14 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>> Said commit (98d72909f8) made the building of static_prog and
>>> static_nonifunc_prog conditional, but then only added conditionals to
>>> the tests involving the former. Also conditionalize the ones involving
>>> the latter.
>>>
>>> ld/
>>> 2018-08-02  Jan Beulich  <jbeulich@suse.com>
>>>
>>>         * testsuite/ld-ifunc/ifunc.exp: Also skip tests involving
>>>         static_nonifunc_prog when static builds are not possible.
>>>
>
>>
>> STATIC_LDFLAGS only applies to tests which are linked against libc.a.
>> Are the above tests linked against libc.a?
>
> That's a question you should answer, I think, considering the original
> change of yours where you suppress the building of static_nonifunc_prog
> when STATIC_LDFLAGS is empty. The issue I'm observing is that the
> binary simply doesn't exist, and hence the tests fail.
>

I checked in this patch instead.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ifunc.exp-Always-build-static_nonifunc_prog.patch
Type: text/x-patch
Size: 1668 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20180802/f3e1b235/attachment.bin>