First-time binutils repository code-stare - indentation and contribution process

Maciej W. Rozycki macro@mips.com
Mon Nov 13 10:45:00 GMT 2017


On Thu, 9 Nov 2017, Nick Clifton wrote:

> > In readelf.c I see some inconsistent mixed use of real tabs and spaces
> > on the same line. I assume the normal convention applies where you
> > leave existing invalid whitespace alone, but use the correct style for
> > new code?
> 
> Actually the old code ought to be corrected as well.  Although it is better
> to do so as a separate set of patches, rather than including such changes
> along with new code.

 Fixing formatting issues alone however has the drawback of obfuscating 
`git blame' output, so it may be good to weigh on a case by case basis 
whether it is worth it.

 FWIW,

  Maciej



More information about the Binutils mailing list