[PATCH 4/4] ld: Add ldlang_check_relro_region/update lang_find_relro_sections_1

[H.J. Lu]

On Sun, Nov 12, 2017 at 4:12 PM, Alan Modra <amodra@gmail.com> wrote:
> On Sun, Nov 12, 2017 at 09:31:51AM -0800, H.J. Lu wrote:
>>       (ldlang_check_relro_region): New function.
>>       (lang_find_relro_sections_1): Add an argument for pointer to
>
> This is a nitpick, but most other functions that have a
> lang_statement_union_type* argument have it as the first parameter.
> It obviously doesn't matter, but I think it would be nicer for
> consistency if you kept the same parameter order here.

Good idea.  Here is the updated patch.

> Other than that, the patch series looks fine to me.
>

I am checking it in together with the rest of series.

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ld-Add-ldlang_check_relro_region-update-lang_find_re.patch
Type: text/x-patch
Size: 4130 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20171113/e6099ee4/attachment.bin>