[PATCH] gold: Ignore definition from a dynamic object for __start/__stop

[H.J. Lu]

On Wed, Nov 8, 2017 at 3:50 PM, Cary Coutant <ccoutant@gmail.com> wrote:
> +   // Skip if the old definition is from a regular object.
> +   if (!oldsym->is_from_dynobj())
> +     return NULL;
> +
> +   // If the symbol has the hidden or internal visibility, ignore
> +   // definition and reference from a dynamic object.
> +   if ((visibility == elfcpp::STV_HIDDEN
> +        || visibility == elfcpp::STV_INTERNAL)
> +       && !oldsym->in_reg())
>
> s/the hidden/hidden/
>
> The last if statement really just ignores the symbol if it hasn't been
> referenced in a regular object. The first if statement takes care of
> the case where the definition was in a dynamic object.
>
> OK with updated comment.
>

This is what I am checking in.


H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gold-Ignore-def-ref-from-a-dynamic-object-for-specia.patch
Type: text/x-patch
Size: 7856 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20171109/8f219b9f/attachment.bin>