[gold commit] PR 19823: Don't allow COPY relocs to protected symbols

Cary Coutant ccoutant@gmail.com
Tue Jun 28 19:48:00 GMT 2016


>> Is there any reason we shouldn't just skip that test case for targets
>> that don't normally use copy relocs?
>
> I'd be happy with simply skipping the test.  As it is, it is
> particularly nasty since failing that one test stops the majority of
> the other tests running, even with "make -k".
>
> Like this then?
>
>         * testsuite/Makefile.am (copy_test_protected): Disable for powerpc.
>         * testsuite/Makefile.in: Regenerate.

This is OK. Thanks!

After the branch, I think I'll look at making this test intelligently
skip itself if the expected non-pic code sequences aren't there.

-cary



More information about the Binutils mailing list