[gold commit] PR 19823: Don't allow COPY relocs to protected symbols

Alan Modra amodra@gmail.com
Tue Jun 28 00:57:00 GMT 2016


On Mon, Jun 27, 2016 at 10:40:45AM -0700, Cary Coutant wrote:
> Is there any reason we shouldn't just skip that test case for targets
> that don't normally use copy relocs?

I'd be happy with simply skipping the test.  As it is, it is
particularly nasty since failing that one test stops the majority of
the other tests running, even with "make -k".

Like this then?

	* testsuite/Makefile.am (copy_test_protected): Disable for powerpc.
	* testsuite/Makefile.in: Regenerate.

diff --git a/gold/testsuite/Makefile.am b/gold/testsuite/Makefile.am
index 25ee126..7edf7a7 100644
--- a/gold/testsuite/Makefile.am
+++ b/gold/testsuite/Makefile.am
@@ -843,6 +843,7 @@ copy_test_2_pic.o: copy_test_2.cc
 copy_test_2.so: gcctestdir/ld copy_test_2_pic.o
 	$(CXXLINK) -shared copy_test_2_pic.o
 
+if !DEFAULT_TARGET_POWERPC
 check_SCRIPTS += copy_test_protected.sh
 check_DATA += copy_test_protected.err
 MOSTLYCLEANFILES += copy_test_protected.err
@@ -854,6 +855,7 @@ copy_test_protected.err: copy_test_protected.o copy_test_2.so gcctestdir/ld
 	  rm -f $@; \
 	  exit 1; \
 	fi
+endif
 
 if TLS
 

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list