as error output not -j64 safe
Matthew Fortune
Matthew.Fortune@imgtec.com
Tue May 20 22:49:00 GMT 2014
> This patch has broken a lot of expected output in the gas testsuite.
> Are individual ports expected to deal with the fallout or has this been
> done already but awaiting commit? MIPS has 133 failures with this patch
> applied.
I didn't check the exact cause earlier. It is just extra whitespace
introduced in the refactoring. Committed as obvious, (hoping that is the
right way to treat this sort of fix).
Regards,
Matthew
* messages.c (as_warn_internal): Remove extra whitespace from
warning messages.
---
gas/ChangeLog | 5 +++++
gas/messages.c | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 130b287..51974b5 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,10 @@
2014-05-20 Matthew Fortune <matthew.fortune@imgtec.com>
+ * messages.c (as_warn_internal): Remove extra whitespace from
+ warning messages.
+
+2014-05-20 Matthew Fortune <matthew.fortune@imgtec.com>
+
* config/tc-mips.c (FP64_ASES): Add ASE_MSA.
(mips_after_parse_args): Do not select ASE_MSA without -mfp64.
diff --git a/gas/messages.c b/gas/messages.c
index 05c7442..d592b36 100644
--- a/gas/messages.c
+++ b/gas/messages.c
@@ -151,12 +151,12 @@ as_warn_internal (char *file, unsigned int line, char *buffer)
if (file)
{
if (line != 0)
- fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Warning: "), buffer);
+ fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Warning:"), buffer);
else
- fprintf (stderr, "%s: %s %s\n", file, _("Warning: "), buffer);
+ fprintf (stderr, "%s: %s %s\n", file, _("Warning:"), buffer);
}
else
- fprintf (stderr, "%s %s\n", _("Warning: "), buffer);
+ fprintf (stderr, "%s %s\n", _("Warning:"), buffer);
#ifndef NO_LISTING
listing_warning (buffer);
#endif
--
1.7.1
> > -----Original Message-----
> > From: binutils-owner@sourceware.org [mailto:binutils-
> owner@sourceware.org]
> > On Behalf Of Mike Stump
> > Sent: 20 May 2014 21:28
> > To: Alan Modra
> > Cc: Andrew Pinski; binutils
> > Subject: Re: as error output not -j64 safe
> >
> > On May 16, 2014, at 1:51 AM, Alan Modra <amodra@gmail.com> wrote:
> > > OK.
> >
> > Thanks. I noticed you tricksy people switched to git, welcome to 2005.
> >
> > > Please also fix as_warn_internal similarly to the above.
> >
> > Done.
> >
> > > There are quite a few more cases of the same problem in this file, if
> you
> > > care to look..
> >
> > Gosh, I want to solve these with fmemopen, but, that is not as portable
> as
> > the existing code... In any event, I'm not set up to do as much testing
> as
> > I'd like for move invasive changes...
> >
> > Here is what I checked in:
> >
> > 2014-05-20 Mike Stump <mikestump@comcast.net>
> >
> > * messages.c (as_warn_internal): Ensure we don't interleave output
> > within a single line when make -j is used.
> > (as_bad_internal): Likewise.
More information about the Binutils
mailing list