[PATCH 5/6] Add Visium support to gas

[Eric Botcazou]

> Heh.  I'd like an explanation too.  :)  If the clearing is necessary
> it indicates to me that you have a bug somewhere in md_assemble
> setting the field non-zero..

Removed.

> BTW, since your target is rela, you don't need to write to the field
> if you're emitting a reloc (which will happen if fx_done is clear on
> exit from md_apply_fix).  It's cleaner to leave the field zero rather
> than writing in the addend.
> 
> Also, I don't see any check on fx_subsy.  You should emit an error if
> fx_subsy is present and not handled.

Neither tc-i386.c nor tc-sparc.c does that though.

> > +  /* Are we finished with this relocation now?  */
> > +  if (fixP->fx_addsy == 0 && !fixP->fx_pcrel)
> > +    fixP->fx_done = 1;
> 
> That !fixP->fx_pcrel lools suspicious.  Why punt all pcrel to the
> linker?

Because tc-sparc.c does exactly the same?  Removed.

-- 
Eric Botcazou