[PATCH] MIPS EVA ASE Support
Moore, Catherine
Catherine_Moore@mentor.com
Mon Jun 17 20:41:00 GMT 2013
> -----Original Message-----
> From: Richard Sandiford [mailto:rdsandiford@googlemail.com]
> Sent: Wednesday, June 12, 2013 2:38 PM
> To: Rozycki, Maciej
> Cc: Moore, Catherine; binutils@sourceware.org
> Subject: Re: [PATCH] MIPS EVA ASE Support
>
> "Maciej W. Rozycki" <macro@codesourcery.com> writes:
> >> {
> >> - /* A 12-bit or 0-bit offset field is too narrow to be used
> >> - for a low-part relocation, so load the whole address into
> >> - the auxillary register. In the case of "A(b)" addresses,
> >> + /* A 12-bit, 0-bit or 9-bit offset field is too narrow to be
> >
> > Suggest sorting the bit count, i.e.:
> >
> > /* A 12-bit, 9-bit or 0-bit offset field is too narrow to be
>
> Bikeshed stuff, but I'd prefer "The offset field is too narrow..."
> and drop the list altogether.
>
> > I'll let Richard comment on the rest.
>
> My only other comment is: rather than
>
> if (mips_opts.micromips)
> offbits = 12;
>
> please use:
>
> offbits = (mips_opts.micromips ? 12 : 16);
>
> (several instances).
>
Hi Richard,
Okay, new patch with these changes plus Maciej's suggestions. OK?
Thanks,
Catherine
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eva.cl4
Type: application/octet-stream
Size: 1949 bytes
Desc: eva.cl4
URL: <https://sourceware.org/pipermail/binutils/attachments/20130617/ba2c92ba/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eva.patch4
Type: application/octet-stream
Size: 174641 bytes
Desc: eva.patch4
URL: <https://sourceware.org/pipermail/binutils/attachments/20130617/ba2c92ba/attachment-0001.obj>
More information about the Binutils
mailing list