[PATCH] MIPS EVA ASE Support
Richard Sandiford
rdsandiford@googlemail.com
Wed Jun 12 18:38:00 GMT 2013
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
>> {
>> - /* A 12-bit or 0-bit offset field is too narrow to be used
>> - for a low-part relocation, so load the whole address into
>> - the auxillary register. In the case of "A(b)" addresses,
>> + /* A 12-bit, 0-bit or 9-bit offset field is too narrow to be
>
> Suggest sorting the bit count, i.e.:
>
> /* A 12-bit, 9-bit or 0-bit offset field is too narrow to be
Bikeshed stuff, but I'd prefer "The offset field is too narrow..."
and drop the list altogether.
> I'll let Richard comment on the rest.
My only other comment is: rather than
if (mips_opts.micromips)
offbits = 12;
please use:
offbits = (mips_opts.micromips ? 12 : 16);
(several instances).
Thanks,
Richard
More information about the Binutils
mailing list