Fix some PR ld/3809 MIPS failures (part 2)

Richard Sandiford rdsandiford@googlemail.com
Mon Mar 19 21:13:00 GMT 2012


Hans-Peter Nilsson <hans-peter.nilsson@axis.com> writes:
> Namely, that for 32-bit embedded MIPS targets, there this test failure:
>
> Running
> /mnt/test1/hp/axis/binutils/src/ld/testsuite/ld-mips-elf/mips-elf.exp ...
> ...
> FAIL: Global calls from mips16
>
> Looking at the dump file and the
> ld-mips-elf/mips16-call-global.d file, the issue seems to be
> that sections are 16-byte aligned everywhere else than for
> mips*-elf and mips*-vxworks; see comment in the patch.  So,
> don't run the tests on those targets.
>
> (Part 1 is regarding the other FAILS in the PR.)
>
> Tested with 'RUNTESTFLAGS=mips-elf.exp' cross to mipsel-linux,
> mipsisa32r2el-linux, mipsisa32r2el-elf, mipsisa32r2-elf,
> mipsel-elf, mips-elf, mips-sgi-irix6, mips-sgi-irix5,
> mipsel-sde-elf, mips64-kfreebsd-gnu, mips-dde-sysv4.2MP (a
> "mips-*-sysv*" yields ECOFF; a gas/ld inconsistency wart?),
> mipsisa64-sde-elf, mipsisa64el-elf, mips-freebsd8.2,
> mips64el-freebsd7.3, mips64-freebsd8.1, mipsel-freebsd7.2.
> together with the other posted fixes: lots of failures for
> mips-sgi-irix6 but none remaining for this test.  Results for
> *-freebsd* are blank and uninteresting as they returned too
> early due to mips-elf.exp gating on is_elf_target; see
> <http://sourceware.org/ml/binutils/2012-03/msg00039.html>.
>
> Ok?

I'd prefer adding ".align 4" to each .s file.  That's preapproved
if it works.

Richard



More information about the Binutils mailing list