This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Committed: fix ld/configure.tgt for mips*-freebsd*


An obvious typo, correction committed as such.  It's obvious
when looking at configure mips*-freebsd* checks in other
binutils directories and observing that FreeBSD GNU triplets
(not referring to the kFreeBSD thingy) look like
<arch>-freebsd<releasemajor>.<releaseminor>.  It seemed only the
mips* entries had this typo.

This change apparently lacked sufficient testing.  A suitable
penance would be testing recent binutils and GCC releases and
submitting results for inclusion in the
<http://gcc.gnu.org/buildstat.html> pages, for any *-freebsd*
(sic; not kfreebsd) and GCC releases missing recorded results (I
looked there to get the gist of the general status of FreeBSD
support).

It's also obvious binutils could use some MIPS FreeBSD T.L.C.:
CVS HEAD cannot have been built since 2010-12-31 when the
breaking patch was committed.

Tested by building crosses for mips-freebsd8.2,
mips64el-freebsd7.3, mips64-freebsd8.1, mipsel-freebsd7.2
(canonical names: s/-freebsd/-unknown-freebsd/) which fails in
ld without this patch, as follows:
...
checking whether ANSI C string concatenation works... yes
*** ld does not support target mips-unknown-freebsd8.2
*** see ld/configure.tgt for supported targets
make[2]: *** [configure-ld] Error 1

Another FreeBSD-related wart, noticed while testing the fix for
the issues I really had in mind (this being a side-track for
issues with testresults for other MIPS targets), is that
binutils/testsuite/lib/binutils-common.exp:is_elf_format returns
0 for *-freebsd* targets, while is_aout_format returns 1 only
for freebsd[12].  That also seems just wrong, but I leave that
for people actually interested in FreeBSD.

ld:
	* configure.tgt (mips64*el-*-freebsd*, mips64*-*-freebsd*)
	(mips*el-*-freebsd*, mips*-*-freebsd*): Correct triplets by
	replacing trailing "-*" with "*".

Index: configure.tgt
===================================================================
RCS file: /cvs/src/src/ld/configure.tgt,v
retrieving revision 1.257
diff -p -u -r1.257 configure.tgt
--- configure.tgt	25 Feb 2012 19:51:34 -0000	1.257
+++ configure.tgt	4 Mar 2012 01:35:39 -0000
@@ -409,19 +409,19 @@ mips*el-*-linux-*)	targ_emul=elf32ltsmip
 mips*-*-linux-*)	targ_emul=elf32btsmip
 			targ_extra_emuls="elf32ltsmip elf32btsmipn32 elf64btsmip elf32ltsmipn32 elf64ltsmip"
 			targ_extra_libpath=$targ_extra_emuls ;;
-mips64*el-*-freebsd-* | mips64*el-*-kfreebsd*-gnu)
+mips64*el-*-freebsd* | mips64*el-*-kfreebsd*-gnu)
 			targ_emul=elf32ltsmipn32_fbsd
 			targ_extra_emuls="elf32ltsmip elf32btsmip elf32ltsmipn32 elf32btsmipn32 elf64ltsmip elf64btsmip elf32ltsmip_fbsd elf32btsmip_fbsd elf32btsmipn32_fbsd elf64ltsmip_fbsd elf64btsmip_fbsd"
 			targ_extra_libpath=$targ_extra_emuls ;;
-mips64*-*-freebsd-* | mips64*-*-kfreebsd*-gnu)
+mips64*-*-freebsd* | mips64*-*-kfreebsd*-gnu)
 			targ_emul=elf32btsmipn32_fbsd
 			targ_extra_emuls="elf32ltsmip elf32btsmip elf32ltsmipn32 elf32btsmipn32 elf64ltsmip elf64btsmip elf32ltsmip_fbsd elf32btsmip_fbsd elf32ltsmipn32_fbsd elf64ltsmip_fbsd elf64btsmip_fbsd"
 			targ_extra_libpath=$targ_extra_emuls ;;
-mips*el-*-freebsd-* | mips*el-*-kfreebsd*-gnu)
+mips*el-*-freebsd* | mips*el-*-kfreebsd*-gnu)
 			targ_emul=elf32ltsmip_fbsd
 			targ_extra_emuls="elf32ltsmip elf32btsmip elf32ltsmipn32 elf32btsmipn32 elf64ltsmip elf64btsmip elf32ltsmipn32_fbsd elf32btsmip_fbsd elf32btsmipn32_fbsd elf64ltsmip_fbsd elf64btsmip_fbsd"
 			targ_extra_libpath=$targ_extra_emuls ;;
-mips*-*-freebsd-* | mips*-*-kfreebsd*-gnu)
+mips*-*-freebsd* | mips*-*-kfreebsd*-gnu)
 			targ_emul=elf32btsmip_fbsd
 			targ_extra_emuls="elf32ltsmip elf32btsmip elf32ltsmipn32 elf32btsmipn32 elf64ltsmip elf64btsmip elf32ltsmip_fbsd elf32btsmipn32_fbsd elf32ltsmipn32_fbsd elf64ltsmip_fbsd elf64btsmip_fbsd"
 			targ_extra_libpath=$targ_extra_emuls ;;

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]