[PATCH] Add plugin interface to LD [4/4] Add files, libs and dir paths.

Richard Henderson rth@redhat.com
Wed Oct 6 22:40:00 GMT 2010


On 09/22/2010 10:32 PM, Dave Korn wrote:
> +#ifdef ENABLE_PLUGINS
> +  union lang_statement_union **listend;
> +#endif /* ENABLE_PLUGINS */
...
>  #ifdef ENABLE_PLUGINS
>    /* Now all files are read, let the plugin(s) decide if there
>       are any more to be added to the link before we call the
>       emulation's after_open hook.  */
> +  listend = statement_list.tail;
> +  ASSERT (!*listend);

Better to merge these two with a set of braces inside
the second ENABLE_PLUGINS ifdef.

> +  osec = osec;
> +  oval = oval;

Please just use ATTRIBUTE_UNUSED.

Otherwise ok.


r~



More information about the Binutils mailing list