[PATCH,committed] Fix PR12166.

Dave Korn dave.korn.cygwin@gmail.com
Fri Nov 5 05:00:00 GMT 2010


    Hi list,


  The attached patch fixes PR12166.  The bug is caused by the code that
derives a mangled weak external aux symbol name being overcautious about
something that can't happen (attempting to de-prefix a name after it has also
had a uniquify-ing suffix added), but the overcautious code does get falsely
tripped when there's a dot in the symbol.  The same symbol never gets frobbed
twice, so all this is unnecessary.

gas/ChangeLog:

2010-11-05  Dave Korn  <...redacted...>

	* config/obj-coff.c (weak_altname2name): Don't infer from the presence
	of a period that the symbol has been already uniquify-d.
	(weak_uniquify): Don't worry that the symbol might have been already
	uniquify-d.

  Bootstrapped and tested i686-pc-cygwin, then used for several GCC
bootstrap-and-test cycles with no anomalies.  Committed.

    cheers,
      DaveK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr12166.diff
Type: text/x-c
Size: 979 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20101105/f00d8e29/attachment.bin>


More information about the Binutils mailing list