PATCH: PR ld/11146: Add "readelf --dyn-syms"

[H.J. Lu]

On Mon, Jan 11, 2010 at 5:51 AM, Daniel Jacobowitz <dan@codesourcery.com> wrote:
> On Mon, Jan 11, 2010 at 12:28:03PM +0000, Nick Clifton wrote:
>> Hi H.J.
>>
>> >binutils/
>> >2010-01-07  H.J. Lu  <hongjiu.lu@intel.com>
>> >
>> >     PR ld/11146
>> >     * readelf.c (do_dyn_syms): New.
>> >     (OPTION_DYN_SYMBS): Likewise.
>
> Why syms versus symbs?
>
> It seems to me very confusing to have -Ds (dynamic symbols) and
> --dyn-syms.  The description in the manual sounds like -Ds and
> --dyn-syms should both do what your new patch does.  I wouldn't
> be able to tell the difference.  Is the existing -Ds useful?  If both
> are useful, the manual should differentiate them.  If the other is not
> useful, just change -Ds.
>
> --

Here is the updated patch with updated document for -Ds. I didn't
change -Ds since someone may expect the current behavior.

-- 
H.J.
---
binutils/

2010-01-11  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/11146
	* readelf.c (do_dyn_syms): New.
	(OPTION_DYN_SYMS): Likewise.
	(options): Add "dyn-syms".
	(usage): Add --dyn-syms.
	(parse_args): Handle OPTION_DYN_SYMS.
	(process_symbol_table): Handle do_dyn_syms.
	(process_object): Likewise.
	(process_archive): Likewise.

	* doc/binutils.texi: Document --dyn-syms for readelf.  Mention
	symbol hash tables for -D.

ld/testsuite/

2010-01-11  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/11146
	* ld-elf/dynsym1.d: New.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: binutils-pr11146-2.patch
Type: text/x-csrc
Size: 6454 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20100111/b07d7bc1/attachment.bin>