[PATCH 08/20] MIPS/GAS: Improve a LUI complaint message

Maciej W. Rozycki macro@codesourcery.com
Thu Dec 9 22:53:00 GMT 2010


On Tue, 7 Dec 2010, Richard Sandiford wrote:

> Like Paul, I think the first order ("expression is not in the range A..B")
> sounds more natural.  There again, the liberal dropping of words makes
> the thing sound wrong whatever we do.
> 
> Patch is OK with the original word order.

 Can't argue with a native English speaker. ;)  This is what I applied, 
thanks.

2010-12-09  Maciej W. Rozycki  <macro@codesourcery.com>

	* config/tc-mips.c (mips_ip) <'u'>: Report the value of the LUI
	argument complained about; reword the message.

  Maciej

binutils-gas-mips-msg-lui.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c	2010-12-09 02:34:52.000000000 +0000
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c	2010-12-09 02:34:53.000000000 +0000
@@ -10014,7 +10014,8 @@ mips_ip (char *str, struct mips_cl_insn 
 		  && imm_expr.X_op == O_constant
 		  && (imm_expr.X_add_number < 0
 		      || imm_expr.X_add_number >= 0x10000))
-		as_bad (_("lui expression not in range 0..65535"));
+		as_bad (_("lui expression (%lu) not in range 0..65535"),
+			(unsigned long) imm_expr.X_add_number);
 	      s = expr_end;
 	      continue;
 



More information about the Binutils mailing list