[PATCH 08/20] MIPS/GAS: Improve a LUI complaint message

[Richard Sandiford]

Patches 4-7 OK

"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
> ===================================================================
> --- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c	2010-12-01 21:05:50.000000000 +0000
> +++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c	2010-12-01 21:05:50.000000000 +0000
> @@ -10005,7 +10005,8 @@ mips_ip (char *str, struct mips_cl_insn 
>  		  && imm_expr.X_op == O_constant
>  		  && (imm_expr.X_add_number < 0
>  		      || imm_expr.X_add_number >= 0x10000))
> -		as_bad (_("LUI expression not in range 0..65535"));
> +		as_bad (_("LUI expression (%lu) not in 0..65535 range"),
> +			(unsigned long) imm_expr.X_add_number);
>  	      s = expr_end;
>  	      continue;

Like Paul, I think the first order ("expression is not in the range A..B")
sounds more natural.  There again, the liberal dropping of words makes
the thing sound wrong whatever we do.

Patch is OK with the original word order.

Richard