[PATCH] New --pe-dll-characteristcs switch for PE ld.

Dave Korn dave.korn.cygwin@googlemail.com
Thu Mar 12 13:59:00 GMT 2009

Nick Clifton wrote:
> Hi Dave, Hi Danny,

  'lo Nick!

>>> The following implements Dave's patch as per Chris's suggestions.
> Well I consider this patch to be good but not quite ready for prime time.  This
> is because of ...
>> Thanks a bunch for picking this up, Danny.  I'll take your patch for a spin 
>> through my autotester and let you know if anything crops up.
> My regression tester shows the following new linker testsuite failures

  I was just collating a list of the same failures to post here when you posted!

> All of these fail because of an internal error in the linker.  For example the
> i686-pc-cygwin target reports:
> internal error: aborting at ei386pe.c line 400 in set_pe_name

  Hadn't got to the rebuild yet, but I see it now.  Danny, there's a mismatch
between the init[] entry

+   D(DllCharacteristics, "__dll_characteristics__", 0x0),

and the call to set_pe_name:

+   set_pe_name ("__dllcharacteristics__", pe_dll_characteristics);

  I'll test the obvious fix.


More information about the Binutils mailing list