ARM long branch stubs: cleanup

Paul Brook paul@codesourcery.com
Mon Mar 9 13:04:00 GMT 2009


On Friday 06 March 2009, Christophe LYON wrote:
> Hi all,
>
> With the attached small patch, I propose to remove an error-prone switch
> statement to get the correct stub template and size in arm_size_one_stub().
> It is replaced by an (error-prone :-) array defined next to the stub
> themselves.
>
> Maybe it would save some maintenance issues.

If you rework the preprocessor macros a bit you can generate both the enum and 
the array from the same list.

Something along the lines of
#define DEF_STUBS DEF_STUB(long_branch_any)[...]

#define DEF_STUB(x) arm_stub_##x,
enum{
  DEF_STUBS
}
#undef DEF_STUB

#define DEF_STUB(x) elf32_arm_stub_##x,
static const stub_def stub_definitions[] = {
 DEF_STUBS
}

Paul



More information about the Binutils mailing list