[Patch - hppa] add compile time check for immediate values of

[Helge Deller]

John David Anglin wrote:
>> +/* Store immediate values of shift/deposit/extract functions.  */
>> +
>> +#define SAVE_IMMEDIATE(VALUE) \
>> +  { \
>> +    if (immediate_check) \
>> +      { \
>> +	if (pos == -1) \
>> +	  pos = VALUE; \
>> +	else \
>> +	  if (len == -1) \
>> +	    len = VALUE; \
>> +      } \
>> +  }
> 
> Another minor tweak.  Put parentheses around the uses of "VALUE".

Ok.
 
> It's ok to have "else if" on one line. 

Ok.

> However, body of the first
> if should be indented.  The only exception to that rule is case
> statements.

It is indented, but with tab which is why it maybe looked wrong.
Anyway, I'll respin :-)

> The patch is ok with that change.

Thanks!

Helge