[Patch - hppa] add compile time check for immediate values of

John David Anglin dave@hiauly1.hia.nrc.ca
Sun Feb 22 20:32:00 GMT 2009


> +/* Store immediate values of shift/deposit/extract functions.  */
> +
> +#define SAVE_IMMEDIATE(VALUE) \
> +  { \
> +    if (immediate_check) \
> +      { \
> +	if (pos == -1) \
> +	  pos = VALUE; \
> +	else \
> +	  if (len == -1) \
> +	    len = VALUE; \
> +      } \
> +  }

Another minor tweak.  Put parentheses around the uses of "VALUE".

It's ok to have "else if" on one line. However, body of the first
if should be indented.  The only exception to that rule is case
statements.

The patch is ok with that change.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)



More information about the Binutils mailing list