PATCH COMMITTED: Fix gold common symbol sorting

Ian Lance Taylor iant@google.com
Thu Mar 27 20:05:00 GMT 2008


I made a dumb mistake in the sorting routine for the common symbols.
I noticed it because the instable sorting routine caused a linker
segmentation fault in one of the gcc test cases.

I committed this patch to fix it, with a test case.

Ian


2008-03-27  Ian Lance Taylor  <iant@google.com>

	* common.cc (Sort_commons::operator): Correct sorting algorithm.
	* testsuite/common_test_1.c: New file.
	* testsuite/Makefile.am (check_PROGRAMS): Add common_test_1.
	(common_test_1_SOURCES): New variable.
	(common_test_1_DEPENDENCIES): New variable.
	(common_test_1_LDFLAGS): New variable.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-patch
Size: 4419 bytes
Desc: Fix common symbol sorting
URL: <https://sourceware.org/pipermail/binutils/attachments/20080327/dccbc5a1/attachment.bin>


More information about the Binutils mailing list