Your gas changes caused weakref failures for cris-elf, supposedly others too

[Jan Beulich]

Hmm, interesting. Which way to fix this actually depends on the
intentions with weak references - if they're supposed to be
re-definable, then assign_symbol() or s_weakref() would need to take
care of this. If not, the test is broken. Alexandre, can you clarify the
intentions?

Thanks, Jan

>>> Hans-Peter Nilsson <hans-peter.nilsson@axis.com> 27.10.05 12:40:49
>>>
After this change:

2005-10-27  Jan Beulich  <jbeulich@novell.com>

	* read.c (assign_symbol): Also consider equates already
defined.
	* symbols.c (symbol_clone): Also clone the underlying BFD
symbol.
	* config/obj-coff.h (obj_symbol_clone_hook): New.
	(coff_obj_symbol_clone_hook): Declare.
	* config/obj-coff.c (coff_obj_symbol_clone_hook): New.

My autotester, building for "--target=cris-axis-elf" caught
these failures:

Running /h/hp/binutils/cvs_latest/src/gas/testsuite/gas/all/gas.exp
...
FAIL: weakref tests, relocations
FAIL: weakref tests, global syms
FAIL: weakref tests, local syms
FAIL: weakref tests, strong undefined syms
FAIL: weakref tests, weak undefined syms

with this in gas.log:
/h/hp/binutils/cvs_latest/src/gas/testsuite/lib/run ../as-new   -o
dump.o /h/hp/binutils/cvs_latest/src/gas/testsuite/gas/all/weakref1.s
/h/hp/binutils/cvs_latest/src/gas/testsuite/gas/all/weakref1.s:
Assembler messages:
/h/hp/binutils/cvs_latest/src/gas/testsuite/gas/all/weakref1.s:203:
Error: symbol `lr1' is already defined
/h/hp/binutils/cvs_latest/src/gas/testsuite/gas/all/weakref1.s:208:
Error: symbol `lr2' is already defined
/h/hp/binutils/cvs_latest/src/gas/testsuite/gas/all/weakref1.s:226:
Error: symbol `lr6' is already defined
/n/asic_slask/hp/autobinutest/gas/testsuite/../../binutils/objdump  -r
dump.o > dump.out
/n/asic_slask/hp/autobinutest/gas/testsuite/../../binutils/objdump:
'dump.o': No such file
FAIL: weakref tests, relocations

same for the rest of the failures.

brgds, H-P