ARM: Fix DT_TEXTREL generation

Daniel Jacobowitz drow@false.org
Tue Mar 29 20:00:00 GMT 2005


On Tue, Mar 29, 2005 at 04:22:08PM +0100, Richard Earnshaw wrote:
> On Fri, 2005-03-25 at 16:01, Daniel Jacobowitz wrote:
> > I posted this patch a couple days ago, but at the bottom of a thread ...
> > tsk tsk.
> > 
> > This patch prevents the incorrect generation of a DT_TEXTREL tag in ARM
> > shared libraries.  The problem was that p->count was correctly updated,
> > but we would sometimes create new relocs_copied entries with a zero count;
> > and when checking for text relocations, we don't look at the count, just
> > whether the pointer is non-NULL.  The cleanest fix is to avoid creating a
> > new relocs_copied structure if we aren't going to increment it.
> > 
> > OK for HEAD?  Any objection to fixing this on 2.16 also?
> 
> This is OK for head.  For the record, I'm happy for this to go into 2.16
> too, but I'm not sure if that's my call.

It's your call - or mine, as release manager.  Since we're both happy,
I'll commit it to both.

-- 
Daniel Jacobowitz
CodeSourcery, LLC



More information about the Binutils mailing list