ARM: Fix DT_TEXTREL generation

Richard Earnshaw rearnsha@gcc.gnu.org
Tue Mar 29 16:21:00 GMT 2005


On Fri, 2005-03-25 at 16:01, Daniel Jacobowitz wrote:
> I posted this patch a couple days ago, but at the bottom of a thread ...
> tsk tsk.
> 
> This patch prevents the incorrect generation of a DT_TEXTREL tag in ARM
> shared libraries.  The problem was that p->count was correctly updated,
> but we would sometimes create new relocs_copied entries with a zero count;
> and when checking for text relocations, we don't look at the count, just
> whether the pointer is non-NULL.  The cleanest fix is to avoid creating a
> new relocs_copied structure if we aren't going to increment it.
> 
> OK for HEAD?  Any objection to fixing this on 2.16 also?

This is OK for head.  For the record, I'm happy for this to go into 2.16
too, but I'm not sure if that's my call.
R.



More information about the Binutils mailing list