[RFA:] ar test failure fix

[Hans-Peter Nilsson]

> Date: Tue, 07 Jun 2005 19:51:16 -0700
> From: Mark Mitchell <mark@codesourcery.com>

> Hans-Peter Nilsson wrote:
> > Mark, did you really run the testsuite after your bfd-fopen ABI
> > changes, in a *clean* directory (no partial test-results or
> > left-over files)?  My autotester for cris-elf did, and got
> > (after the recent new-port-commit debacle and switch braino was
> > fixed, that is):
> 
> I ran the GDB testsuite, and built Binutils with --enable-target=all. 
> Was I supposed to run the binutils testsuite too?

When you change anything in binutils, including bfd, yes.

> > Looking closer, it seems you added a call to bfd_error but
> > didn't make a corresponding clearing call.
> 
> I wondered about that.  But, bfd_fdopenr was that way before; it called 
>   bfd_set_error (bfd_error_system_call), but never cleared it.  All I 
> did was preserve that behavior.  Was that a latent bug?

My patch is for bfd_fopen which only did that on error, not bfd_fdopenr.

So there *is* a latent bug.

brgds, H-P