bfd/elf/mn10300 "dangerous error"

[Ian Lance Taylor]

DJ Delorie <dj@redhat.com> writes:

> in elf-m10300.c we have code like this:
> 
> 	    case bfd_reloc_dangerous:
> 	      msg = _("internal error: dangerous error");
> 	      goto common_error;
> 
> 	    common_error:
> 	      if (!((*info->callbacks->warning)
> 		    (info, msg, name, input_bfd, input_section,
> 		     rel->r_offset)))
> 		return FALSE;
> 	      break;
> 
> Why doesn't bfd_reloc_dangerous invoke the dangerous_reloc callback?
> The way it is now, dangerous relocs let the linker succeed, because
> they're only warnings.

The notion of what dangerous means is target dependent.  Some
dangerous relocs should only be warnings.  Some should be fatal
errors.  I don't know which is the case for elf-m10300.c.

Ian