RFA: Don't canonicalize STT_SECTION syms
Hans-Peter Nilsson
hp@bitrange.com
Fri Dec 10 03:15:00 GMT 2004
On Wed, 8 Dec 2004, Daniel Jacobowitz wrote:
> 2004-12-08 Daniel Jacobowitz <dan@codesourcery.com>
>
> * elfcode.h (elf_slurp_reloc_table_from_section): Don't canonicalize
> ELF section symbols.
This patch caused the following errors in the gas testsuite for
mmix-knuth-mmixware:
...
Running /home/hp/combined/combined/gas/testsuite/gas/mmix/mmix.exp ...
FAIL: gas/mmix/basep-10
FAIL: gas/mmix/basep-11
FAIL: gas/mmix/basep-9
FAIL: gas/mmix/comment-3
FAIL: gas/mmix/fb-1
FAIL: gas/mmix/fb-2
FAIL: gas/mmix/greg1
FAIL: gas/mmix/greg1a
FAIL: gas/mmix/greg2
FAIL: gas/mmix/greg2a
FAIL: gas/mmix/greg3
FAIL: gas/mmix/greg4
FAIL: gas/mmix/greg5
FAIL: gas/mmix/greg6
FAIL: gas/mmix/greg7
FAIL: gas/mmix/greg8
FAIL: gas/mmix/odd-1
FAIL: gas/mmix/prefix1
FAIL: gas/mmix/prefix3
FAIL: gas/mmix/relax2
The error seems in all cases to be that the section name in
relocs isn't printed but instead, nothing. For example, the
first error from gas.log:
...
../as-new -linker-allocated-gregs -o dump.o
/home/hp/combined/combined/gas/testsuite/gas/mmix/basep-10.s
/home/hp/combined/mmixware-sim/gas/testsuite/../../binutils/objdump -srt dump.o > dump.out
regexp_diff match failure
regexp "^0+a R_MMIX_REG \.MMIX\.reg_contents$"
line "000000000000000a R_MMIX_REG "
regexp_diff match failure
regexp "^0+e R_MMIX_REG \.MMIX\.reg_contents\+0x0+8$"
line "000000000000000e R_MMIX_REG +0x0000000000000008"
regexp_diff match failure
regexp "^0+12 R_MMIX_REG \.MMIX\.reg_contents\+0x0+8$"
line "0000000000000012 R_MMIX_REG +0x0000000000000008"
regexp_diff match failure
regexp "^0+8 R_MMIX_64 \.text\+0x0+4$"
line "0000000000000008 R_MMIX_64 +0x0000000000000004"
FAIL: gas/mmix/basep-10
I'm a bit surprised that noone else has reported a problem; this
doesn't seem to be specfific for the MMIX port or some
unconventional corner of it.
Either the patch is in error, or I guess some tweak is needed to
objdump for section symbols. I haven't ran gdb on this yet, but
my bets are on the latter guess, since apparently nothing else
broke (gcc testsuite including c++,objc,libstdc++-v3 included).
brgds, H-P
More information about the Binutils
mailing list