PATCH: binutils + i18n

Bruno Haible haible@ilog.fr
Sat Oct 20 09:26:00 GMT 2001


matthew green wrote on 10 October:

> my point is that locale shouldn't matter for a gas parser,
> except it's error messages.  whatever the locale, the input
> should be treated identically...

You are right, and my patch does exactly what you want.

Before this patch, the regular expression looked like
"move[ \t\n]*" and used case-insensitive comparison inside regexec,
i.e. it called tolower/toupper, which are locale dependent.

With the patch, the regular expression looks like
"[mM][oO][vV][eE][ \t\n]*" and uses case-sensitive comparison inside
regexec, i.e. no locale dependent calls. Also the conversion from
"move" to "[mM][oO][vV][eE]" uses the macros from "safe-ctype.h" which
are locale independent.

Bruno



More information about the Binutils mailing list