Geoff Keating geoffk@ozemail.com.au
Wed Oct 27 16:33:00 GMT 1999

In elf32.em, there's this code:

     FIXME: This approach--using bfd_elf_set_dt_needed_name--is not
     very pretty.  I haven't been able to think of anything that is
     pretty, though.  */
  if (bfd_check_format (entry->the_bfd, bfd_object)
      && (entry->the_bfd->flags & DYNAMIC) != 0)
      char *filname, *needed_name;

      ASSERT (entry->is_archive && entry->search_dirs_flag);

      /* Rather than duplicating the logic above.  Just use the
	 filename we recorded earlier.o

	 First strip off everything before the last '/'.  */
      filename = strrchr (entry->filename, '/');

Shouldn't the variable be called 'filename'?

Geoffrey Keating <geoffk@cygnus.com>

More information about the Binutils mailing list